forked from cline/cline
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: Move Import/Export to Modes view toolbar (#8686) #9077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hannesrudolph
wants to merge
6
commits into
RooCodeInc:main
Choose a base branch
from
hannesrudolph:feat/issue-8686-modes-toolbar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Move Import/Export to Modes view toolbar (#8686) #9077
hannesrudolph
wants to merge
6
commits into
RooCodeInc:main
from
hannesrudolph:feat/issue-8686-modes-toolbar
+613
−611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-review completed. The latest commit adds a useEffect hook to reset the import level to "project" each time the import dialog opens. This ensures consistent default behavior and works correctly with the existing controlled radio button components. No issues found. Mention @roomote to ask your PR Fixer agent to address the feedback. |
…ooCodeInc#9003 Removes import auto-select logic introduced in this PR: - Removed prevModesForImportRef and snapshot-based detection - Removed customModesRef used only for import logic - Removed auto-select behavior in importModeResult handler PR RooCodeInc#9003 implements a better backend-driven approach for import auto-select. This change prevents merge conflicts; we keep create/delete auto-select which is unique to our PR.
… undefined for built-ins; controlled import level state; delegate delete fallback to backend
… stale selection across opens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR - Needs Preliminary Review
size:XXL
This PR changes 1000+ lines, ignoring generated files.
UI/UX
UI/UX related or focused
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the non‑technical summary of what changed:
No commits or pushes have been made.
Important
Move Import/Export buttons to the toolbar in
ModesView.tsx, maintaining existing functionality and removing them from the bottom section.ModesView.tsx, next to the "Create new mode" button.ModesView.tsx.vscode.postMessage.This description was created by
for f8f63c5. You can customize this summary. It will automatically update as commits are pushed.