-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix(webview): address PR #8556 feedback (platform-aware key hints, i18n fixes, follow-up focus) #9078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Re-review complete. The previously identified issue has been resolved. Issues resolved:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
| "label": "Comprimi i messaggi di pensiero per impostazione predefinita", | ||
| "description": "Se abilitato, i blocchi di pensiero verranno compressi per impostazione predefinita finché non interagisci con essi" | ||
| "label": "Comprimi i messaggi di pensiero per impostazione predefinita" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collapseThinking object is missing its description field, which breaks the JSON structure. This will cause i18n lookups to fail when users try to view this setting in Italian.
| }, | |
| "collapseThinking": { | |
| "label": "Comprimi i messaggi di pensiero per impostazione predefinita", | |
| "description": "Se abilitato, i blocchi di pensiero verranno compressi per impostazione predefinita finché non interagisci con essi" | |
| }, |
Fix it with Roo Code or mention @roomote and request a fix.
| "label": "Comprimi i messaggi di pensiero per impostazione predefinita", | ||
| "description": "Se abilitato, i blocchi di pensiero verranno compressi per impostazione predefinita finché non interagisci con essi" | ||
| "label": "Comprimi i messaggi di pensiero per impostazione predefinita" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The collapseThinking object is missing its description field, which breaks the JSON structure. This will cause i18n lookups to fail when users try to view this setting in Italian.
| }, | |
| "collapseThinking": { | |
| "label": "Comprimi i messaggi di pensiero per impostazione predefinita", | |
| "description": "Se abilitato, i blocchi di pensiero verranno compressi per impostazione predefinita finché non interagisci con essi" | |
| }, |
Fix it with Roo Code or mention @roomote and request a fix.
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
58c93eb to
31ab4be
Compare
…tform key renders in Settings; clean ChatView lint
This PR supersedes #8556 to land the requested fixes because the original branch is on a fork and is not pushable from this environment.
Related GitHub Issue
Closes: #8555
Description
This PR introduces a new toggle in the settings under the "UI" section that allows users to switch between two input behaviors in the chat prompt editor:
The change is implemented by listening to the keydown event in the prompt input component and conditionally intercepting the Enter key based on the user’s preference, which is stored via VS Code’s configuration API.
This addresses user pain points around accidental submissions, ergonomic fatigue from holding Shift, and conflicts with input method workflows.
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
The settings panel

Didn't send the message after pressing enter:

Did send it when pressing ctrl+enter

Documentation Updates
Additional Notes
Get in Touch
Discord: lmtr0
Important
Adds a toggle for switching input behaviors in chat prompt editor, with platform-aware key handling and i18n updates.
ChatTextArea.tsxto intercept Enter key based on user preference.requireCtrlEnterToSendtoglobal-settings.tsandClineProvider.ts.SettingsView.tsxandUISettings.tsxto include new toggle.ChatTextArea.spec.tsxfor new keyboard handling behavior.platform.tsfor platform detection and key combination utilities.This description was created by
for 8571f3b. You can customize this summary. It will automatically update as commits are pushed.