Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Feb 10, 2025

Description

Let's do a bit better job of requiring a specific node version. Continue.dev using Node 20, and some of our npm packages are warning that are potentially not compatible with Node 18.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Update Node.js version to v20.18.1 across workflows, .nvmrc, flake.nix, and package.json for consistency and compatibility.

  • Node.js Version Update:
    • Set NODE_VERSION to 20.18.1 in .github/workflows/changeset-release.yml, code-qa.yml, and marketplace-publish.yml.
    • Update .nvmrc to v20.18.1.
    • Change nodejs_18 to nodejs_20 and corepack_18 to corepack_20 in flake.nix.
    • Update package.json to require Node.js >=20.18.1 in engines field.
  • Workflows:
    • Modify node-version to use NODE_VERSION environment variable in setup-node steps in workflows.
    • Ensure all jobs in workflows use Node.js v20.18.1 for consistency.

This description was created by Ellipsis for 1ac3770. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2025

⚠️ No Changeset found

Latest commit: 1ac3770

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hannesrudolph hannesrudolph moved this to To triage in Roo Code Roadmap Mar 5, 2025
@hannesrudolph hannesrudolph moved this from To triage to PR - Needs Approval in Roo Code Roadmap Mar 6, 2025
@mrubens mrubens moved this from PR [Unverified] to PR [Greenlit] in Roo Code Roadmap Mar 10, 2025
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 19, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Mar 19, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]


Generated with ❤️ by ellipsis.dev

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Mar 19, 2025
@cte cte merged commit 70a5d2b into main Mar 19, 2025
12 checks passed
@cte cte deleted the cte/node-version branch March 19, 2025 17:46
@github-project-automation github-project-automation bot moved this from PR [Greenlit] to Done in Roo Code Roadmap Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants