ascon-aead: rewrite internals to use inout #673
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
Author
|
The inout bits gets tested in fef7771 |
Contributor
|
What is the benefit of this? How does it compare in overhead to u8 slices? |
Member
|
It allows us to use disjoint buffers for plaintext and ciphertext, which allows us to remove unnecessary copies in some cases. As for overhead, in the worst case compiler would have to keep track of one additional destination pointer, but in most cases compiler should see that source and destination pointers are the same. |
Contributor
|
ascon-aead will be maintained elsewhere going forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #665