ConstChoice improvements #440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ct_choicemodule toconst_choice, to match the struct nameCtChoice#418 (in a way) - nowLimb'ssubtleimpls piggyback onConstChoice, so that we don't have two different algorithms doing the same thing. I use the Hacker's Delight approach - it is marginally safer, and doesn't seem to lead to performance reduction.constequivalent ofsubtle::CtOption#422 - addConstOptionand use it across the API.I thought about adding
NonZero::const_new_unchecked()andConstOption::unwrap_unchecked()for use in tight loops, but usingexpectdoesn't seem to decrease performance.