ed448-goldilocks: clean up benchmarks
#1386
Merged
+12
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
ed448-bench-2
branch
from
7b3a60e to
3564a0e
Compare
49 tasks
daxpedda
force-pushed
the
ed448-bench-2
branch
from
3564a0e to
ca7416f
Compare
daxpedda
force-pushed
the
ed448-bench-2
branch
from
ca7416f to
affa984
Compare
tarcieri
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some real-world usage, I've noticed that we can cut down on some unnecessary benchmarks.
Among a couple of other nits, the main thing here is that I removed
hash_to_curve(), becauseencode_to_curve()+ point addition already covers that.Follow-up to #1334.