Skip to content

ed448-goldilocks: clean up benchmarks #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

ed448-goldilocks: clean up benchmarks #1386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 12 additions & 42 deletions ed448-goldilocks/benches/bench.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use criterion::{BatchSize, Criterion, criterion_group, criterion_main};
use ed448_goldilocks::{
CompressedDecaf, CompressedEdwardsY, Decaf448, DecafPoint, DecafScalar, EdwardsPoint,
EdwardsScalar, MontgomeryPoint,
Decaf448, DecafPoint, DecafScalar, EdwardsPoint, EdwardsScalar, MontgomeryPoint,
};
use elliptic_curve::group::GroupEncoding;
use elliptic_curve::{Field, Group};
Expand Down Expand Up @@ -36,18 +35,6 @@ pub fn ed448(c: &mut Criterion) {
)
});

group.bench_function("hash_to_curve", |b| {
b.iter_batched(
|| {
let mut msg = [0; 64];
OsRng.try_fill_bytes(&mut msg).unwrap();
msg
},
|msg| EdwardsPoint::hash_with_defaults(&msg),
BatchSize::SmallInput,
)
});

group.bench_function("encode_to_curve", |b| {
b.iter_batched(
|| {
Expand All @@ -63,15 +50,15 @@ pub fn ed448(c: &mut Criterion) {
group.bench_function("compress", |b| {
b.iter_batched(
|| EdwardsPoint::try_from_rng(&mut OsRng).unwrap(),
|point| point.to_bytes().0,
|point| point.to_bytes(),
BatchSize::SmallInput,
)
});

group.bench_function("decompress", |b| {
b.iter_batched(
|| EdwardsPoint::try_from_rng(&mut OsRng).unwrap().to_bytes().0,
|bytes| CompressedEdwardsY(bytes).decompress().unwrap(),
|| EdwardsPoint::try_from_rng(&mut OsRng).unwrap().to_bytes(),
|bytes| EdwardsPoint::from_bytes(&bytes).unwrap(),
BatchSize::SmallInput,
)
});
Expand Down Expand Up @@ -106,23 +93,6 @@ pub fn decaf448(c: &mut Criterion) {
)
});

group.bench_function("hash_to_curve", |b| {
b.iter_batched(
|| {
let mut msg = [0; 64];
OsRng.try_fill_bytes(&mut msg).unwrap();
msg
},
|msg| {
Decaf448::hash_from_bytes::<ExpandMsgXof<Shake256>>(
&[&msg],
&[b"decaf448_XOF:SHAKE256_D448MAP_RO_"],
)
},
BatchSize::SmallInput,
)
});

group.bench_function("encode_to_curve", |b| {
b.iter_batched(
|| {
Expand All @@ -140,27 +110,27 @@ pub fn decaf448(c: &mut Criterion) {
)
});

group.bench_function("compress", |b| {
group.bench_function("encode", |b| {
b.iter_batched(
|| DecafPoint::try_from_rng(&mut OsRng).unwrap(),
|point| point.compress().0,
|point| point.to_bytes(),
BatchSize::SmallInput,
)
});

group.bench_function("decompress", |b| {
group.bench_function("decode", |b| {
b.iter_batched(
|| DecafPoint::try_from_rng(&mut OsRng).unwrap().compress().0,
|bytes| CompressedDecaf(bytes).decompress().unwrap(),
|| DecafPoint::try_from_rng(&mut OsRng).unwrap().to_bytes(),
|bytes| DecafPoint::from_bytes(&bytes).unwrap(),
BatchSize::SmallInput,
)
});

group.finish();
}

pub fn curve448(c: &mut Criterion) {
let mut group = c.benchmark_group("Curve448");
pub fn x448(c: &mut Criterion) {
let mut group = c.benchmark_group("X448");

group.bench_function("scalar multiplication", |b| {
b.iter_batched(
Expand All @@ -178,5 +148,5 @@ pub fn curve448(c: &mut Criterion) {
group.finish();
}

criterion_group!(benches, ed448, decaf448, curve448);
criterion_group!(benches, ed448, decaf448, x448);
criterion_main!(benches);