Restructure marker and paddleocr packages#43
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the marker and paddleocr packages by moving them from the src/ocr/ directory to dedicated workspace packages in packages/ocr/. The change improves dependency management by using uv workspaces and updates Docker configurations for better caching.
- Converted
markerandpaddleocrfrom nested modules to standalone workspace packages - Updated Docker configurations to use multi-stage builds with dependency caching
- Simplified environment variable handling using
DATA_FOLDERconsistently across services
Reviewed Changes
Copilot reviewed 21 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ocr/paddleocr/* | Removed old paddleocr implementation files |
| src/ocr/marker/* | Removed old marker implementation files |
| packages/ocr/paddleocr/* | New paddleocr workspace package with pyproject.toml |
| packages/ocr/marker/* | New marker workspace package with simplified API |
| src/api/app/routers/*.py | Updated to use aiohttp for async requests and simplified environment handling |
| docker-compose.yml | Updated build contexts and volume mounting for new package structure |
| pyproject.toml | Added new workspace members and optional dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #42:
packages/ocr/markerandpackages/ocr/paddleocrpackages asuvworkspacespyonb_paddleocrAPI and Dockerfile to be consistent with the other OCR tools inpyonbpyonb_markerandpyonb_paddleocrDockerfiles to cache dependenciesDATA_FOLDERfor mounting themarkerandpaddleocrdata volumespyonband running inference withmarkerandpaddleocrmarkeranddocling