test: [Orchestration] Extend Grounding Unit Test #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
reviewed
Jan 16, 2025
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
Show resolved
Hide resolved
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java
Outdated
Show resolved
Hide resolved
newtork
reviewed
Jan 17, 2025
Comment on lines
+160
to
+178
| final var groundingConfigConfig = | ||
| GroundingModuleConfigConfig.create() | ||
| .inputParams(List.of("query")) | ||
| .outputParam("results") | ||
| .addFiltersItem(databaseFilter); | ||
| final var groundingConfig = | ||
| GroundingModuleConfig.create() | ||
| .type(GroundingModuleConfig.TypeEnum.DOCUMENT_GROUNDING_SERVICE) | ||
| .config(groundingConfigConfig); | ||
| final var configWithGrounding = config.withGroundingConfig(groundingConfig); | ||
|
|
||
| final Map<String, String> inputParams = | ||
| Map.of("query", "String used for similarity search in database"); | ||
| final var prompt = | ||
| new OrchestrationPrompt( | ||
| inputParams, | ||
| Message.system("Context message with embedded grounding results. {{?results}}")); | ||
|
|
||
| final var response = client.chatCompletion(prompt, configWithGrounding); |
Contributor
There was a problem hiding this comment.
(Question)
This is supposed to be the expected convenience API usage, right?
Looks tough.
Member
There was a problem hiding this comment.
no, this is generated code only.
newtork
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#144.
Extend the unit test for covering the request serialisation as well.
Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated