fix: Correct OAuth2 parameter for IAS refresh token workaround #1066
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#ISSUENUMBER.
This changes the OAuth2 token request parameter from
refresh_tokentorefresh_expiryfor named user current withapp_tidto disable refresh token issuance.The documented approach for disabling refresh token issuance is
refresh_expiry=0, but currentlyrefresh_token=0is set instead. The issue that lead to the workaround being added also talks aboutrefresh_expiryand the API documentation only mentionsrefresh_expiry.Feature scope:
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated