Skip to content

fix: Correct OAuth2 parameter for IAS refresh token workaround #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidkna-sap wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: Correct OAuth2 parameter for IAS refresh token workaround #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ivity-oauth/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/OAuth2Service.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ private void setAppTidInCaseOfIAS( @Nullable final String tenantId )
additionalParameters.put("app_tid", tenantId);
if( onBehalfOf == OnBehalfOf.NAMED_USER_CURRENT_TENANT ) {
// workaround until a fix is provided by IAS
additionalParameters.put("refresh_token", "0");
additionalParameters.put("refresh_expiry", "0");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...y-oauth/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/OAuth2ServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ void testSubdomainTenantStrategy()
2,
postRequestedFor(urlEqualTo("/oauth/token"))
.withRequestBody(containing("app_tid=" + tenant.getTenantId()))
.withRequestBody(containing("refresh_token=0"))
.withRequestBody(containing("refresh_expiry=0"))
.withRequestBody(
containing("grant_type=urn:ietf:params:oauth:grant-type:jwt-bearer".replace(":", "%3A")))
.withRequestBody(containing("assertion=")));
Expand Down
2 changes: 1 addition & 1 deletion release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@

### 🐛 Fixed Issues

-
- Fixed IAS OAuth2 token requests to use correct `refresh_expiry=0` parameter instead of `refresh_token=0` to disable refresh token issuance in certain cases.