Update Code Generator for AI SDK #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
newtork
reviewed
Nov 29, 2024
| public {{classname}}() | ||
| { | ||
| super(new AiCoreService().client()); | ||
| super(new AiCoreService().getApiClient()); |
Contributor
There was a problem hiding this comment.
(Hindsight)
This would not have been necessary if we had considered parameterized constructors:
#629 (comment)
Should we consider doing this now?
Member
Author
There was a problem hiding this comment.
true, on the other hand I'd hope we don't have to do frequent changes to this, and if we do, there is the risk the parameters don't exactly fit what we need 😅
No strong opinion though, we also don't have time pressure to implement this, can always be done later on if we like
10 tasks
CharlesDuboisSAP
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Supports this PR: SAP/ai-sdk-java#201
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated