chore: WARN logs removed #984
Conversation
newtork
added
please merge
| .warn( | ||
| "Credential type not found or not recognised in service binding. Defaulting to BINDING_SECRET.")) | ||
| .getOrElse(CredentialType.BINDING_SECRET); | ||
| return getOAuthCredential(CredentialType.class, "credential-type").getOrElse(CredentialType.BINDING_SECRET); |
There was a problem hiding this comment.
(Major)
Can we keep the message? It sounds important to me.
Also shouldn't the AI Core credential actually contain "credential-type"? How is this warn message harming anyone (legitimally)?
There was a problem hiding this comment.
I think it would be ideal to have this message once (i.e., the first time this code is invoked) but not with each and every call because then it really clogs up the logs.
We are trying to fix the problem we saw in the demo in the AI SDK.
There was a problem hiding this comment.
For the protocol, we've found the service-key may or may not contain credential-type in the JSON payload.
But for normal use-cases for classic service-bindings, we want to see WARN messages when important fields are mising.
|
Closed in favor of SAP/ai-sdk-java#636 |
Context
SAP/cloud-sdk-java-backlog#ISSUENUMBER.
Removed the following warning log in response to Backlog Item no.295 in AI SDK :
Credential type not found or not recognised in service binding.Feature scope:
Definition of Done
Functionality scope stated & coveredTests cover the scope aboveError handling created / updated & covered by the tests aboveDocumentation updatedRelease notes updated