Skip to content

chore: WARN logs removed #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n-o-u-r-h-a-n wants to merge 4 commits into from
Closed

chore: WARN logs removed #984

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbf1479
Removing WARN logs for ai-sdk
n-o-u-r-h-a-n Oct 16, 2025
c8638dc
Merge branch 'main' into Improving-Logging
n-o-u-r-h-a-n Oct 24, 2025
1e84cbd
Some Formatting
n-o-u-r-h-a-n Oct 24, 2025
6c91443
Some Formatting again
n-o-u-r-h-a-n Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ...main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultOAuth2PropertySupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,7 @@ private ClientIdentity getSecretIdentity( @Nonnull final String clientid )
@Nonnull
CredentialType getCredentialType()
{
return getOAuthCredential(CredentialType.class, "credential-type")
.onEmpty(
() -> log
.warn(
"Credential type not found or not recognised in service binding. Defaulting to BINDING_SECRET."))
.getOrElse(CredentialType.BINDING_SECRET);
return getOAuthCredential(CredentialType.class, "credential-type").getOrElse(CredentialType.BINDING_SECRET);
Copy link
Contributor

@newtork newtork Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Major)
Can we keep the message? It sounds important to me.
Also shouldn't the AI Core credential actually contain "credential-type"? How is this warn message harming anyone (legitimally)?

Copy link
Member

@Jonas-Isr Jonas-Isr Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be ideal to have this message once (i.e., the first time this code is invoked) but not with each and every call because then it really clogs up the logs.

We are trying to fix the problem we saw in the demo in the AI SDK.

Copy link
Contributor

@newtork newtork Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the protocol, we've found the service-key may or may not contain credential-type in the JSON payload.

But for normal use-cases for classic service-bindings, we want to see WARN messages when important fields are mising.

}

/**
Expand Down