Fix body outputs, proper integration of imu_short and remove dynamic tf-broadcaster for static transform#67
Open
gkueppers wants to merge 7 commits intoSBG-Systems:develfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
We have identified a few minor issues with our Ekinox Micro. First of all, we noticed that the body outputs are dependent on
use_enu, which, in our opinion, does not make sense (see issue #66 ).Furthermore, problems arose during the update when using the new
imu_shortmessage, which we have resolved with the appropriate changes.We are open to feedback on the implementation or possible misunderstandings on our part.
Summary
/sbg/ekf_vel_body,/sbg/ekf_rot_accel_body) independent of theuse_enuflag (Closing Influence onuse_enuon/sbg/ekf_vel_bodyand/sbg/ekf_rot_accel_body#66)imu_dataORimu_shortis availableareStampsCloseto matchimu_shortmessage with other required inputs for imu/odom instead of hard comparison whether timestamp is the same (this was not the case with our Ekinox Micro)odom_init_frame_id_-->odom_frame_id_Possible Open Todo's
The following tasks can be tackled after and based on your initial feedback, if this pull request is conceivable to be merged:
/sbg/imu_shortis missing in published topicsareStampsClosetime_stampinstead ofheader.stampto matchimu_shortmessage with other required inputs for imu/odom