TF tree broken in SbgImuData odometry path#69
Open
TheDelus wants to merge 1 commit intoSBG-Systems:develfrom
Open
TF tree broken in SbgImuData odometry path#69TheDelus wants to merge 1 commit intoSBG-Systems:develfrom
TheDelus wants to merge 1 commit intoSBG-Systems:develfrom
Conversation
This reverts commit 12d38d3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 12d38d3 ("Fix transformations to use correct parents and children frames") inverted the parent/child frame arguments in both fillTransform calls inside the SbgImuData overload of createRosOdoMessage, producing:
This left odom as an orphaned frame, disconnected from both map and base_link, breaking any navigation stack that depends on the standard map → odom → base_link chain (REP105). The SbgImuShort overload was unaffected and already had the correct logic.
Fix
Reverted 12d38d3