Reconstruction and Migration #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge Dn/rotated linear to ac/reconstruction
Angelyr
requested review from
RPIFisherman,
cwsmith and
onkarsahni
as code owners
This was referenced Nov 14, 2024
Closed
onkarsahni
requested changes
Nov 19, 2024
onkarsahni
left a comment
onkarsahni
left a comment
There was a problem hiding this comment.
A few changes needed. I have not reviewed all the changed files yet. Will do it in next round. Thanks.
dhyan1272
reviewed
Nov 26, 2024
onkarsahni
requested changes
Dec 3, 2024
onkarsahni
left a comment
onkarsahni
left a comment
There was a problem hiding this comment.
A few more changes. And I will check 3 files one more time: pmpo_c.cpp pmpo_fortran.f90 testFortranMPAdvection.f90
onkarsahni
requested changes
Dec 10, 2024
onkarsahni
left a comment
onkarsahni
left a comment
There was a problem hiding this comment.
One more change (open a ticket). And then I can merge and close PR. Thanks.
Author
|
Ok, I created that issue |
onkarsahni
approved these changes
Dec 10, 2024
|
PR merged and branch deleted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code and tests for reconstruction and migration