ci: automatically add Reviewed-by trailer when Accepted label is set#8083
Closed
pbrezina wants to merge 1 commit intoSSSD:masterfrom
Closed
ci: automatically add Reviewed-by trailer when Accepted label is set#8083pbrezina wants to merge 1 commit intoSSSD:masterfrom
pbrezina wants to merge 1 commit intoSSSD:masterfrom
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Member
Author
|
This PR should be merged together with #8078, then we can stop using the push script. |
ikerexxe
reviewed
Sep 9, 2025
This introduce new workflow that is run when Accepted label is set. It appends Reviewed-by trailers to all commits in the pull request for all reviewers that ack-ed it. * It is skipped if Accepted label is missing/removed * It is no-op success if PR was synchronized after label was set (this is required to make it green as it is automatically re-run when the job finishes as a side effect to pushing to this repository) * It adds the trailers when Accepted label is added It uses secrets.BOT_TOKEN and SSSD_AUTHORS variable that contains mapping from github account to name and email. Since PR CI is restarted when commits with Reviewed-by are pushed, the job also submits comment with current PR CI status, so it is not lost and we do not have to necessarily wait for new PR CI run to finish.
pbrezina
force-pushed
the
reviewedby
branch
from
682e2bf to
1b852f9
Compare
alexey-tikhonov
approved these changes
Sep 10, 2025
Member
|
Let's try this :) |
6 tasks
pbrezina
added
Ready to push
backport-to-sssd-2-10
backport-to-sssd-2-9-4
Member
Author
|
Pushed PR: #8083
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduce new workflow that is run when Accepted label is set.
It appends Reviewed-by trailers to all commits in the pull request for
all reviewers that ack-ed it.
is required to make it green as it is automatically re-run when the
job finishes as a side effect to pushing to this repository)
It uses secrets.BOT_TOKEN and SSSD_AUTHORS variable that contains
mapping from github account to name and email.
Since PR CI is restarted when commits with Reviewed-by are pushed, the
job also submits comment with current PR CI status, so it is not lost
and we do not have to necessarily wait for new PR CI run to finish.
PR comment example: pbrezina#86 (comment)
SSSD_AUTHORS variable can be edited here: https://github.com/SSSD/sssd/settings/variables/actions/SSSD_AUTHORS