SHS-6056: Allow external access to Localist API methods#58
Open
codechefmarc wants to merge 2 commits intoSU-SWS:8.xfrom
Open
SHS-6056: Allow external access to Localist API methods#58codechefmarc wants to merge 2 commits intoSU-SWS:8.xfrom
codechefmarc wants to merge 2 commits intoSU-SWS:8.xfrom
Conversation
11 tasks
|
Got it, thanks @cienvaras |
pookmish
requested changes
May 15, 2025
Collaborator
pookmish
left a comment
There was a problem hiding this comment.
Field widgets aren't intended to be used like this. They have a dedicated purpose and that does not work with this approach.
If you'd like to perform something like this, extract the functionality out into a service. then the service can be used inside the field widget.
|
@cienvaras See Mike's comment above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
LocalistUrlWidgetso they are public to be able to be accessed from outside the widget and adds a$base_urlparameter that can be passed by the external calls.Review By (Date)
3/5/2025
Criticality
Urgency
Review Tasks
Setup tasks and/or behavior to test
/admin/structure/migrate/localist-eventsSite Configuration Sync
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
@mentionthem here)Resources