Skip to content

Remove deprecated set_audit_log_postal_address function and task#847

Open
helylle wants to merge 1 commit intomainfrom
ylle-remove-deprecated-audit-backfill-helper
Open

Remove deprecated set_audit_log_postal_address function and task#847
helylle wants to merge 1 commit intomainfrom
ylle-remove-deprecated-audit-backfill-helper

Conversation

@helylle
Copy link
Contributor

@helylle helylle commented Feb 16, 2026

Remove deprecated set_audit_log_postal_address from msg worker

Summary

Remove the deprecated set_audit_log_postal_address method and its Celery task wrapper from workers/msg/tasks.py. Both were marked @deprecated("This function/task seems unused").

Context

The function was originally used by a backfill/migration script in staging and production repos to look up postal addresses from Navet and attach them to transaction audit log entries. Those migration scripts are no longer relevant and will be removed from their respective repos.

No callers exist within this repository — the function was only invoked externally via the Celery task queue.

Changes

  • Removed MessageSender.set_audit_log_postal_address() method (was at line 283)
  • Removed set_audit_log_postal_address Celery task function (was at line 444)
  • Removed now-unused from eduid.common.decorators import deprecated import

Verification

  • make reformat — clean
  • make lint — clean
  • make typecheck — clean
  • No other references in the codebase:
    grep -rn "set_audit_log_postal_address" src/eduid --include="*.py"  # 0 results
    

@sonarqubecloud
Copy link

@helylle helylle marked this pull request as ready for review February 16, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants