Skip to content

Remove deprecated set_audit_log_postal_address function and task #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
helylle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove deprecated set_audit_log_postal_address function and task #847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions src/eduid/workers/msg/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from smscom import SMSClient

from eduid.common.config.base import EduidEnvironment
from eduid.common.decorators import deprecated
from eduid.userdb.exceptions import ConnectionError
from eduid.workers.msg.cache import CacheMDB
from eduid.workers.msg.common import MsgCelerySingleton
Expand Down Expand Up @@ -280,22 +279,6 @@ def _get_navet_data(self, identity_number: str) -> dict[str, Any] | None:
self.cache("navet_cache").add_cache_item(identity_number, json_data)
return json_data

@deprecated("This function seems unused")
def set_audit_log_postal_address(self, audit_reference: str) -> bool:
from eduid.userdb import MongoDB

conn = MongoDB(self.MONGODB_URI)
db = conn.get_database(TRANSACTION_AUDIT_DB)
log_entry = db[TRANSACTION_AUDIT_COLLECTION].find_one({"data.audit_reference": audit_reference})
if log_entry and log_entry.get("data", {}).get("recipient", None):
result = get_postal_address(log_entry["data"]["recipient"])
if result:
address_dict = dict(result)
log_entry["data"]["navet_response"] = address_dict
db[TRANSACTION_AUDIT_COLLECTION].update({"_id": log_entry["_id"]}, log_entry)
return True
return False

@TransactionAudit()
def sendsms(self, recipient: str, message: str, reference: str) -> str:
"""
Expand Down Expand Up @@ -440,20 +423,6 @@ def get_relations_to(self: MessageSender, identity_number: str, relative_nin: st
raise self.retry(default_retry_delay=1, max_retries=3, exc=e) from e


@app.task(bind=True, base=MessageSender)
@deprecated("This task seems unused")
def set_audit_log_postal_address(self: MessageSender, audit_reference: str) -> bool:
"""
Looks in the transaction audit collection for the audit reference and make a postal address lookup and adds the
result to the transaction audit document.
"""
try:
return self.set_audit_log_postal_address(audit_reference)
except Exception as e:
logger.error(f"set_audit_log_postal_address task error: {e}", exc_info=True)
raise e


@app.task(bind=True, base=MessageSender, name="eduid_msg.tasks.pong")
def pong(self: MessageSender, app_name: str | None = None) -> str:
"""
Expand Down