[circle-mlir/infra] Bump h5py to 3.12.1 for Python 3.13 support#16433
Open
arkq wants to merge 1 commit intoSamsung:masterfrom
Open
[circle-mlir/infra] Bump h5py to 3.12.1 for Python 3.13 support#16433arkq wants to merge 1 commit intoSamsung:masterfrom
arkq wants to merge 1 commit intoSamsung:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates Circle-MLIR infrastructure Python dependencies to support Python 3.13 by bumping h5py to a version that provides 3.13 wheels, and by allowing Python 3.13 in the local venv setup script.
Changes:
- Allow Python 3.13 as a supported version in
infra/overlay/prepare-venv. - Bump
h5pyfrom3.8.0to3.12.1in the venv setup script and Ubuntu Docker images.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| circle-mlir/infra/overlay/prepare-venv | Adds Python 3.13 acceptance and updates the pinned h5py version used for local dev venvs. |
| circle-mlir/infra/docker/noble/Dockerfile | Updates h5py pin in the Ubuntu 24.04-based build image venv. |
| circle-mlir/infra/docker/jammy/Dockerfile | Updates h5py pin in the Ubuntu 22.04-based build image venv. |
| circle-mlir/infra/docker/focal/Dockerfile | Updates h5py pin in the Ubuntu 20.04-based build image venv. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This commit bumps h5py package to version 3.12.1. This is the first version which supports Python 3.13. Changes has been tested with upgraded ONNX-MLIR and LLVM in order to compile with GCC 15.2.0 which is the default compiler on Ubuntu 25.04. Used tags for these projects: GIT_TAG_ONNXMLIR: 8524104871c9a5c23973753e0f99ea8b42e3c943 GIT_TAG_LLVMPROJ: 0c2701fe7fa002e1befc5f86c268a7964f96d286 ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <a.bokowy@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit bumps h5py package to version 3.12.1. This is the first version which supports Python 3.13.
Changes has been tested with upgraded ONNX-MLIR and LLVM in order to compile with GCC 15.2.0 which is the default compiler on Ubuntu 25.04. Used tags for these projects:
GIT_TAG_ONNXMLIR: 8524104871c9a5c23973753e0f99ea8b42e3c943
GIT_TAG_LLVMPROJ: 0c2701fe7fa002e1befc5f86c268a7964f96d286
Also, I've verified that it is possible to setup
circle-mlir/infra/docker/{jammy,noble}Docker images. Thefocalseems to be broken in the current master (the stepapt-get -qqy install python3.10 python3.10-venv python3.10-dev dh-pythondoes not work), so I was not able to test it, but considering that jammy and noble are OK, it should also be OK.