feat(gfpoly_factor_edf): add one testcase multiple times#39
Merged
Sarsum merged 1 commit intoSarsum:mainfrom Nov 25, 2025
Merged
feat(gfpoly_factor_edf): add one testcase multiple times#39Sarsum merged 1 commit intoSarsum:mainfrom
Sarsum merged 1 commit intoSarsum:mainfrom
Conversation
Yep, that's the same testcase 20 times as this failed for me if a bad random polynomials have been choosen.
Owner
|
works for me 🚀 I am also removing a value in certain cases, is that not part of the default algorithm? |
Collaborator
Wdym? |
Owner
|
I was just curious why the issue arose, as the slides contain this edgecase: |
Contributor
Author
It is. But my implementation sets the value of this factor to nil which might lead to a nil pointer dereference in the next loop run. |
Owner
|
Ahh alright :D |
niri81
approved these changes
Nov 25, 2025
Contributor
Author
|
Merge it if you think having these cases is worth it. TBH, I don't care as I test this case in my unit test, too. |
Owner
|
I was just curious how these arose. But they definitely might be useful for others! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yep, that's the same EDF testcase 20 times.
This testcase failed for me if a bad random polynomials have been chosen (in approx. 30%-40% of the cases).