Enable download utility selection#1257
Merged
Gauravtalreja1 merged 1 commit intoSatelliteQE:masterfrom Feb 5, 2025
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
dosas
force-pushed
the
download-utility
branch
from
7250f71 to
6c98734
Compare
vsedmik
requested changes
Jan 2, 2025
Contributor
vsedmik
left a comment
vsedmik
left a comment
There was a problem hiding this comment.
Just a small proposal to consider
dosas
force-pushed
the
download-utility
branch
from
6c98734 to
66d264a
Compare
dosas
force-pushed
the
download-utility
branch
from
66d264a to
5cb0126
Compare
vsedmik
approved these changes
Jan 10, 2025
Collaborator
Author
|
@Gauravtalreja1 would you mind to review? |
Collaborator
Author
|
Any news on this? |
Gauravtalreja1
approved these changes
Feb 5, 2025
Member
Gauravtalreja1
left a comment
Gauravtalreja1
left a comment
There was a problem hiding this comment.
ACK, @dosas Do you mind rebasing this PR for merge?
Thank you!!
dosas
force-pushed
the
download-utility
branch
from
5cb0126 to
5c9fdf5
Compare
Collaborator
Author
Done. Could you merge it? |
Gauravtalreja1
approved these changes
Feb 5, 2025
This was referenced Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add download_utility property to RegistrationCommand
Upstream API documentation, plugin, or feature links
Option was added to foreman recently https://github.com/theforeman/foreman/blob/develop/app/controllers/api/v2/registration_commands_controller.rb#L28