refactor: remove use of a custom pagination structure#484
Merged
Conversation
EtienneM
force-pushed
the
fix/429/use_pagination
branch
from
10b0e25 to
d7fefb1
Compare
1 task
EtienneM
force-pushed
the
fix/429/use_pagination
branch
4 times, most recently
from
86885c9 to
0154a57
Compare
EtienneM
requested review from
matthieu526-scalingo
and removed request for
a team
EtienneM
force-pushed
the
fix/429/use_pagination
branch
from
0154a57 to
46de730
Compare
EtienneM
force-pushed
the
fix/429/use_pagination
branch
from
46de730 to
30b3625
Compare
matthieu526-scalingo
approved these changes
Mar 4, 2026
Contributor
matthieu526-scalingo
left a comment
matthieu526-scalingo
left a comment
There was a problem hiding this comment.
One question, but approving already.
pagination.go
Outdated
| "github.com/Scalingo/go-utils/pagination" | ||
| ) | ||
|
|
||
| func paginationRequestToMap(paginationReq pagination.Request) map[string]string { |
Contributor
There was a problem hiding this comment.
question: shouldn't this be provided by the library? It looks rather generic.
Member
Author
There was a problem hiding this comment.
I hesitated... but you are right. I'll suggest a new PR with this included
Member
Author
There was a problem hiding this comment.
Done in ffc429b using the PR Scalingo/go-utils#1494. I'm pausing this PR waiting for the approval of the go-utils PR.
Member
Author
There was a problem hiding this comment.
Update to the last go-utils/pagination version is done in 1e8bc5f. Tested in Scalingo/cli#1195.
1 task
EtienneM
force-pushed
the
fix/429/use_pagination
branch
from
9208d47 to
ffc429b
Compare
EtienneM
force-pushed
the
fix/429/use_pagination
branch
from
ffc429b to
1e8bc5f
Compare
matthieu526-scalingo
approved these changes
Mar 4, 2026
Contributor
matthieu526-scalingo
left a comment
matthieu526-scalingo
left a comment
There was a problem hiding this comment.
praise: Thanks for making the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this PR by updating the CLI: Scalingo/cli#1195
Fix #429