refactor: expand remaining braces in catalog globs#4608
Merged
github-actions[bot] merged 1 commit intoSchemaStore:masterfrom Mar 23, 2025
Merged
refactor: expand remaining braces in catalog globs#4608github-actions[bot] merged 1 commit intoSchemaStore:masterfrom
github-actions[bot] merged 1 commit intoSchemaStore:masterfrom
Conversation
Continuation/for same reasons as in b5e80eb.
Contributor
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
scop
commented
Mar 22, 2025
Comment on lines
+6191
to
+6199
| "**/manifests/?/*/*/*/*.*.locale.en-US.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.fr-FR.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.it-IT.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.ja-JP.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.ko-KR.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.pt-BR.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.ru-RU.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.zh-CN.yaml", | ||
| "**/manifests/?/*/*/*/*.*.locale.zh-TW.yaml" |
Contributor
Author
There was a problem hiding this comment.
I don't have domain knowledge on this one, but I wonder if this needs to be such a specific enumeration, or if it would be better written as just
Suggested change
| "**/manifests/?/*/*/*/*.*.locale.en-US.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.fr-FR.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.it-IT.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.ja-JP.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.ko-KR.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.pt-BR.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.ru-RU.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.zh-CN.yaml", | |
| "**/manifests/?/*/*/*/*.*.locale.zh-TW.yaml" | |
| "**/manifests/?/*/*/*/*.*.locale.*-*.yaml" |
(...or ...locale.*.yaml).
Member
There was a problem hiding this comment.
That's definitely more appealing as it covers more cases.- Good to leave it as is though
Member
|
LGTM |
Contributor
|
Merging because @hyperupcall is a code-owner of all the changes - thanks! |
scop
added a commit
to scop/schemastore
that referenced
this pull request
Mar 23, 2025
hyperupcall
pushed a commit
that referenced
this pull request
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of/for same reasons as in
b5e80eb, from #4590