Skip to content

refactor: expand remaining braces in catalog globs #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Mar 23, 2025
Merged

refactor: expand remaining braces in catalog globs #4608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions src/api/json/catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,31 +1156,40 @@
{
"name": "dbt Dependencies",
"description": "dbt's dependencies.yml file for external packages and cross-project refs",
"fileMatch": ["**/*dbt*/dependencies.{yaml,yml}"],
"fileMatch": ["**/*dbt*/dependencies.yaml", "**/*dbt*/dependencies.yml"],
"url": "https://raw.githubusercontent.com/dbt-labs/dbt-jsonschema/main/schemas/latest/dependencies-latest.json"
},
{
"name": "dbt Project",
"description": "dbt's project configuration file",
"fileMatch": ["dbt_project.{yaml,yml}"],
"fileMatch": ["dbt_project.yaml", "dbt_project.yml"],
"url": "https://raw.githubusercontent.com/dbt-labs/dbt-jsonschema/main/schemas/latest/dbt_project-latest.json"
},
{
"name": "dbt Packages",
"description": "dbt's packages.yml file for external packages",
"fileMatch": ["**/*dbt*/packages.{yaml,yml}"],
"fileMatch": ["**/*dbt*/packages.yaml", "**/*dbt*/packages.yml"],
"url": "https://raw.githubusercontent.com/dbt-labs/dbt-jsonschema/main/schemas/latest/packages-latest.json"
},
{
"name": "dbt Selectors",
"description": "dbt's selectors.yml file for configuring YAML selectors",
"fileMatch": ["**/*dbt*/selectors.{yaml,yml}"],
"fileMatch": ["**/*dbt*/selectors.yaml", "**/*dbt*/selectors.yml"],
"url": "https://raw.githubusercontent.com/dbt-labs/dbt-jsonschema/main/schemas/latest/selectors-latest.json"
},
{
"name": "dbt YAML files",
"description": "dbt YAML files configurations",
"fileMatch": ["**/*dbt*/{macros,models,seeds,snapshots}/**/*.{yaml,yml}"],
"fileMatch": [
"**/*dbt*/macros/**/*.yaml",
"**/*dbt*/macros/**/*.yml",
"**/*dbt*/models/**/*.yaml",
"**/*dbt*/models/**/*.yml",
"**/*dbt*/seeds/**/*.yaml",
"**/*dbt*/seeds/**/*.yml",
"**/*dbt*/snapshots/**/*.yaml",
"**/*dbt*/snapshots/**/*.yml"
],
"url": "https://raw.githubusercontent.com/dbt-labs/dbt-jsonschema/main/schemas/latest/dbt_yml_files-latest.json"
},
{
Expand Down Expand Up @@ -6179,7 +6188,15 @@
"name": "Windows Package Manager Locale Manifest",
"description": "Windows Package Manager Locale Manifest file, used for detailing locale specific metadata",
"fileMatch": [
"**/manifests/?/*/*/*/*.*.locale.{en-US,fr-FR,it-IT,ja-JP,ko-KR,pt-BR,ru-RU,zh-CN,zh-TW}.yaml"
"**/manifests/?/*/*/*/*.*.locale.en-US.yaml",
"**/manifests/?/*/*/*/*.*.locale.fr-FR.yaml",
"**/manifests/?/*/*/*/*.*.locale.it-IT.yaml",
"**/manifests/?/*/*/*/*.*.locale.ja-JP.yaml",
"**/manifests/?/*/*/*/*.*.locale.ko-KR.yaml",
"**/manifests/?/*/*/*/*.*.locale.pt-BR.yaml",
"**/manifests/?/*/*/*/*.*.locale.ru-RU.yaml",
"**/manifests/?/*/*/*/*.*.locale.zh-CN.yaml",
"**/manifests/?/*/*/*/*.*.locale.zh-TW.yaml"
Comment on lines +6191 to +6199
Copy link
Contributor Author

@scop scop Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have domain knowledge on this one, but I wonder if this needs to be such a specific enumeration, or if it would be better written as just

Suggested change
"**/manifests/?/*/*/*/*.*.locale.en-US.yaml",
"**/manifests/?/*/*/*/*.*.locale.fr-FR.yaml",
"**/manifests/?/*/*/*/*.*.locale.it-IT.yaml",
"**/manifests/?/*/*/*/*.*.locale.ja-JP.yaml",
"**/manifests/?/*/*/*/*.*.locale.ko-KR.yaml",
"**/manifests/?/*/*/*/*.*.locale.pt-BR.yaml",
"**/manifests/?/*/*/*/*.*.locale.ru-RU.yaml",
"**/manifests/?/*/*/*/*.*.locale.zh-CN.yaml",
"**/manifests/?/*/*/*/*.*.locale.zh-TW.yaml"
"**/manifests/?/*/*/*/*.*.locale.*-*.yaml"

(...or ...locale.*.yaml).

Copy link
Member

@hyperupcall hyperupcall Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's definitely more appealing as it covers more cases.- Good to leave it as is though

],
"url": "https://json.schemastore.org/winget-pkgs-locale-1.0.0.json"
},
Expand Down Expand Up @@ -7831,7 +7848,16 @@
{
"name": "Open Know-How",
"description": "Open Source Hardware project metadata",
"fileMatch": ["?(*.)okh.{json,toml,yml,yaml}"],
"fileMatch": [
"okh.json",
"okh.toml",
"okh.yaml",
"okh.yml",
"*.okh.json",
"*.okh.toml",
"*.okh.yaml",
"*.okh.yml"
],
"url": "https://json.schemastore.org/okh.json"
},
{
Expand Down
Loading