Fix LTS extension test failures#1434
Merged
isaacsas merged 3 commits intoSciML:masterfrom Mar 5, 2026
Merged
Conversation
Adding println diagnostics to understand why @test_throws Exception fails on Julia 1.10 LTS Linux x86_64 but passes everywhere else. Will be removed once root cause is identified. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix `import ModelingToolkitBase as MT` crash (not in test deps) by using `Catalyst.MT`. Add constantdefs content printing to both diagnostic blocks to determine whether conslaw_species returns empty because constantdefs is empty or because collect_vars! fails on Julia 1.10. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ompat MT.collect_vars! returns an empty set on Julia 1.10 LTS (x86_64-linux) despite valid conservation law expressions, causing conservationlaw_errorcheck to silently pass when it should throw. Replace with Symbolics.get_variables! which uses a simpler recursive traversal that works across all Julia versions. Also removes temporary CI diagnostic code added for debugging. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
isaacsas
changed the title
Member
|
I have slightly lost track of the various |
TorkelE
approved these changes
Mar 5, 2026
Member
Author
|
Conservation law equations shouldn't ever have anything but variables, so I think this is ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TorkelE seems the issue was the mysterious collect_vars! not working on 1.10 issue again.
Does this fix look ok to you, if so this should get rid of the extension test failure.