Skip to content

Fix LTS extension test failures #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacsas merged 3 commits into from
Mar 5, 2026
+4 −3
Merged

Fix LTS extension test failures #1434

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56efcbc
debug: add temporary diagnostics for LTS BifurcationKit test failures
isaacsas Mar 5, 2026
2edd309
debug: fix broken import and add constantdefs diagnostics for LTS
isaacsas Mar 5, 2026
9366929
fix: use Symbolics.get_variables! in conslaw_species for Julia 1.10 c…
isaacsas Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/network_analysis.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,14 +969,15 @@ function conservationlaw_errorcheck(rs, pre_varmap)
end

# Returns a vector with all species that are invovled in conservation laws.
# Note: uses Symbolics.get_variables! instead of MT.collect_vars! because
# the latter fails to extract variables on Julia 1.10 LTS (empty result
# despite valid input expressions).
function conslaw_species(rs::ReactionSystem)
conservationlaws(rs)
nps = get_networkproperties(rs)
cl_sps = OrderedSet{SymbolicT}()
cl_ps = OrderedSet{SymbolicT}() # Unused, only an input.
iv = Catalyst.get_iv(rs)
for cons_eq in nps.constantdefs
MT.collect_vars!(cl_sps, cl_ps, cons_eq.rhs, iv)
get_variables!(cl_sps, cons_eq.rhs)
end
return cl_sps
end
Expand Down
Loading