Skip to content

Conversation

j-fu
Copy link
Contributor

@j-fu j-fu commented Aug 26, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

This should solve PetrKryslUCSD/Sparspak.jl#38 .

@j-fu
Copy link
Contributor Author

j-fu commented Aug 26, 2025

Added a test for this, however tests run with just one thread, so it probably would not detect anything. Not sure how to fix this.

@ChrisRackauckas
Copy link
Member

If we need to, then we can spin up a multithreaded test group on buildkite https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/.buildkite/pipeline.yml#L34

@j-fu
Copy link
Contributor Author

j-fu commented Aug 26, 2025

I think it would be good to have this available, however I don't feel able to set this up myself. It would be good if someone could add a skeleton for this in a PR.

It would be good to accept the actual PR independent of this in order to resolve the issue linked above (from someone who runs several ODE solves in multiple threads).

@ChrisRackauckas ChrisRackauckas merged commit 940ea1d into SciML:main Aug 27, 2025
130 of 136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants