Skip to content

fix sparspak solves in multithreaded loop #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
+32 −1
Merged

fix sparspak solves in multithreaded loop #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/LinearSolveSparspakExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function SciMLBase.solve!(
cache::LinearSolve.LinearCache, alg::SparspakFactorization; kwargs...)
A = cache.A
if cache.isfresh
if cache.cacheval !== nothing && alg.reuse_symbolic
if !(cache.cacheval === PREALLOCATED_SPARSEPAK) && alg.reuse_symbolic
fact = sparspaklu!(LinearSolve.@get_cacheval(cache, :SparspakFactorization),
SparseMatrixCSC(size(A)..., getcolptr(A), rowvals(A),
nonzeros(A)))
Expand Down
31 changes: 31 additions & 0 deletions test/basictests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,3 +679,34 @@ end
u = solve!(cache)
@test norm(u - u0, Inf) < 1.0e-8
end

@testset "ParallelSolves" begin
n=1000
@info "ParallelSolves: Threads.nthreads()=$(Threads.nthreads())"
A_sparse = 10I - sprand(n, n, 0.01)
B = [rand(n), rand(n)]
U = [A_sparse \ B[i] for i in 1:2]
sol = similar(U)

Threads.@threads for i in 1:2
sol[i] = solve(LinearProblem(A_sparse, B[i]), UMFPACKFactorization())
end

for i in 1:2
@test sol[i] ≈ U[i]
end

Threads.@threads for i in 1:2
sol[i] = solve(LinearProblem(A_sparse, B[i]), KLUFactorization())
end
for i in 1:2
@test sol[i] ≈ U[i]
end

Threads.@threads for i in 1:2
sol[i] = solve(LinearProblem(A_sparse, B[i]), SparspakFactorization())
end
for i in 1:2
@test sol[i] ≈ U[i]
end
end
Loading