Remove defaults for Hydraulic components #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed references to p_int and started debugging the first Hydraulics test case (Fluid Domain and Tube)
The multi volume tube does not solve successfully.
See test/Hydraulic/debugging.jl Ben Chung guided me to adding a continuous_events function that seems to have bug.
Search for "Need Help" in isothermal_compressible.jl under Hydraulic/test
Note where the error was.
| """ | ||
| @component function DynamicVolume(N, add_inertia = true, reversible = false; | ||
| p_int, | ||
| # p_int, |
There was a problem hiding this comment.
Just remove if it's not used?
There was a problem hiding this comment.
Nice catch, resolved
ChrisRackauckas
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Hydraulic components have had defaults removed so that
initialization_eqscan be used to form proper initialization systems. TheDynamicVolumecomponent still has some issues, maybe related to a bug in MTK, and has been tagged with some TODO comments. All base components are working properly with defaults removed.