Skip to content

Remove defaults for Hydraulic components #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 23, 2024
Merged

Remove defaults for Hydraulic components #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5f5a29c
removing p_int and fixing u^2 issue
Sep 11, 2024
882d3f2
MTK9 Initialization Updates
mgithubk Sep 17, 2024
15bf96b
Debugging Fluid Domain and Tube Test
mgithubk Sep 18, 2024
e9dc864
Undefined Reference Error
mgithubk Sep 18, 2024
60b8c58
Working out Tests
mgithubk Sep 19, 2024
0234f51
Update isothermal_compressible.jl
mgithubk Sep 19, 2024
b75cb08
WIP
Sep 20, 2024
20462b1
update translational tests
Sep 23, 2024
6b26bd7
format and cleanup
Sep 23, 2024
4cd2dc0
remove debugging
Sep 23, 2024
5fdfc22
fixed sing_convention.md
Sep 23, 2024
099d5e8
removed commented extras
Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/src/connectors/sign_convention.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,10 @@ using ModelingToolkitStandardLibrary.Hydraulic.IsothermalCompressible

@mtkmodel ConstantMassFlow begin
@parameters begin
p_int
dm
end
@components begin
port = HydraulicPort(; p_int)
port = HydraulicPort()
end
@equations begin
port.dm ~ -dm
Expand All @@ -176,7 +175,7 @@ A positive input mass flow leads to an increasing pressure (in this case we get
```@example sign_convention
@mtkmodel System begin
@components begin
volume = FixedVolume(; vol = 10.0, p_int = 0.0)
volume = FixedVolume(; vol = 10.0)
flow = ConstantMassFlow(; dm = 1)
fluid = HydraulicFluid()
end
Expand Down
Loading
Loading