Add error message when NLopt AUGLAG algorithms are used without local_method #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_method Fixes SciML#1020 NLopt's AUGLAG algorithms require a local optimization method to be specified. Previously, using them without a local_method would result in undefined behavior (returning wrong results like [0.0, 0.0] with Inf objective). This commit adds a clear error message when AUGLAG algorithms are used without specifying a local_method parameter, helping users understand the correct usage. Changes: - Add check in __map_optimizer_args! to detect AUGLAG algorithms without local_method - Provide helpful error message with usage example - Add test cases to verify the error is thrown correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
ChrisRackauckas
approved these changes
Sep 29, 2025
Per review feedback, updated the AUGLAG algorithm check to directly compare against the specific algorithm types (NLopt.LN_AUGLAG, NLopt.LD_AUGLAG, NLopt.AUGLAG) rather than using string pattern matching. This is cleaner and more maintainable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1020
This PR adds a clear error message when NLopt's AUGLAG algorithms are used without specifying a
local_methodparameter, preventing undefined behavior.Problem
As reported in #1020 and confirmed by @ChrisRackauckas, NLopt's AUGLAG algorithms require a local optimization method to function properly. When used without one:
[0.0, 0.0]withInfobjective)Solution
__map_optimizer_args!to check if an AUGLAG algorithm is being used without alocal_methodLN_AUGLAGandLD_AUGLAGTest plan
✅ All existing tests pass
✅ Added specific test cases for the error condition
✅ Manually verified the fix resolves the issue described in #1020
🤖 Generated with Claude Code