Skip to content

Add error message when NLopt AUGLAG algorithms are used without local_method #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Add error message when NLopt AUGLAG algorithms are used without local_method #1026

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c61fd0
Add error message when NLopt AUGLAG algorithms are used without local…
ChrisRackauckas Sep 29, 2025
37f8492
Use direct type comparison for AUGLAG check instead of string matching
ChrisRackauckas Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/OptimizationNLopt/src/OptimizationNLopt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,15 @@ function __map_optimizer_args!(cache::OptimizationCache, opt::NLopt.Opt;
local_maxtime::Union{Number, Nothing} = nothing,
local_options::Union{NamedTuple, Nothing} = nothing,
kwargs...)

# Check if AUGLAG algorithm requires local_method
alg_str = string(opt.algorithm)
if occursin("AUGLAG", alg_str) && local_method === nothing
error("NLopt.$(opt.algorithm) requires a local optimization method. " *
"Please specify a local_method, e.g., solve(prob, NLopt.$(opt.algorithm)(); " *
"local_method = NLopt.LN_NELDERMEAD())")
end

if local_method !== nothing
if isa(local_method, NLopt.Opt)
if ndims(local_method) != length(cache.u0)
Expand Down
4 changes: 4 additions & 0 deletions lib/OptimizationNLopt/test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ using Test, Random
# @test sol.retcode == ReturnCode.Success
@test 10 * sol.objective < l1

# Test that AUGLAG without local_method throws an error
@test_throws ErrorException solve(prob, NLopt.LN_AUGLAG())
@test_throws ErrorException solve(prob, NLopt.LD_AUGLAG())

function con2_c(res, x, p)
res .= [x[1]^2 + x[2]^2 - 1.0, x[2] * sin(x[1]) - x[1] - 2.0]
end
Expand Down
Loading