remove duplicate code

[daviehh]

Checklist

• Appropriate tests were added
• Any code changes were done in a way that does not break public API
• All documentation related to code changes were updated
• The new code follows the
  contributor guidelines, in particular the SciML Style Guide and
  COLPRAC.
• Any new documentation only uses public API

Additional context

current code at

PreallocationTools.jl/src/PreallocationTools.jl

Lines 59 to 68 in 07e3a76

	function get_tmp(dc::FixedSizeDiffCache, u::Union{Number, AbstractArray})
	if promote_type(eltype(dc.du), eltype(u)) <: eltype(dc.du)
	dc.du
	else
	if length(dc.du) > length(dc.any_du)
	resize!(dc.any_du, length(dc.du))
	end
	_restructure(dc.du, dc.any_du)
	end
	end

just calls

PreallocationTools.jl/src/PreallocationTools.jl

Lines 70 to 79 in 07e3a76

	function get_tmp(dc::FixedSizeDiffCache, ::Type{T}) where {T <: Number}
	if promote_type(eltype(dc.du), T) <: eltype(dc.du)
	dc.du
	else
	if length(dc.du) > length(dc.any_du)
	resize!(dc.any_du, length(dc.du))
	end
	_restructure(dc.du, dc.any_du)
	end
	end

with eltype(u), no need to write it separately?

[daviehh]

(format check warnings seems to be not from this PR change but one file in the extension)

[ChrisRackauckas]

don't run the formatter

[ChrisRackauckas]

Wait why would that call the other one? I'm confused. Those dispatches are hit by different inputs.

[daviehh]

current code is duplicate: the first is the same as the second with T -> eltype(u)?

PreallocationTools.jl/src/PreallocationTools.jl

Lines 59 to 79 in fd3df39

	function get_tmp(dc::FixedSizeDiffCache, u::Union{Number, AbstractArray})
	if promote_type(eltype(dc.du), eltype(u)) <: eltype(dc.du)
	dc.du
	else
	if length(dc.du) > length(dc.any_du)
	resize!(dc.any_du, length(dc.du))
	end
	_restructure(dc.du, dc.any_du)
	end
	end
	function get_tmp(dc::FixedSizeDiffCache, ::Type{T}) where {T <: Number}
	if promote_type(eltype(dc.du), T) <: eltype(dc.du)
	dc.du
	else
	if length(dc.du) > length(dc.any_du)
	resize!(dc.any_du, length(dc.du))
	end
	_restructure(dc.du, dc.any_du)
	end
	end

[ChrisRackauckas]

No, the first is dispatching on u being a value, the latter is if a type is given.

[daviehh]

this pr just changes: when dispatched when u is a value, it just calls the 2nd function get_tmp(dc, u::Union{Number, AbstractArray}) = get_tmp(dc, eltype(u)) so the function body is not duplicated

[ChrisRackauckas]

oh good point...