Skip to content

remove duplicate code #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2025
Merged

remove duplicate code #137

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec1e7a5
remove duplicate code
daviehh Aug 18, 2025
e10c6ce
format
daviehh Aug 18, 2025
b233dbd
Revert "format"
daviehh Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/PreallocationTools.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,7 @@ This function enables seamless switching between regular and automatic different
computations without manual cache management.
"""
function get_tmp(dc::FixedSizeDiffCache, u::Union{Number, AbstractArray})
if promote_type(eltype(dc.du), eltype(u)) <: eltype(dc.du)
dc.du
else
if length(dc.du) > length(dc.any_du)
resize!(dc.any_du, length(dc.du))
end
_restructure(dc.du, dc.any_du)
end
get_tmp(dc, eltype(u))
end

function get_tmp(dc::FixedSizeDiffCache, ::Type{T}) where {T <: Number}
Expand Down Expand Up @@ -171,10 +164,12 @@ elements and issues a one-time warning suggesting an appropriate chunk size for
optimal performance.

## Arguments

- `dc`: The `DiffCache` object to enlarge
- `nelem`: The new required number of elements

## Notes

The warning is shown only once per `DiffCache` instance to avoid spam. For optimal
performance in production code, pre-allocate with the suggested chunk size to avoid
runtime allocations.
Expand Down Expand Up @@ -273,7 +268,7 @@ function Base.resize!(dc::DiffCache, n::Integer)
else
throw(ArgumentError("resize! is only supported for DiffCache with vector arrays, got $(typeof(dc.du))"))
end
# dual_du is often pre-allocated for ForwardDiff dual numbers,
# dual_du is often pre-allocated for ForwardDiff dual numbers,
# and may need special handling based on chunk size
# Only resize if it's a vector
if dc.dual_du isa AbstractVector
Expand Down
Loading