Skip to content

Add lb, ub, lcons and ucons for second order BVProblem #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Add lb, ub, lcons and ucons for second order BVProblem #1158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 26 additions & 6 deletions src/problems/bvp_problems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,13 @@ every solve call.
initial value problem, or a `Vector` of values for ``u(t_i)`` for collocation
methods.
* `tspan`: The timespan for the problem.
* `p`: The parameters for the problem. Defaults to `NullParameters`
* `p`: The parameters for the problem. Defaults to `NullParameters`.
* `lb`: The lower bounds for the solution variables. Defaults to `nothing`.
* `ub`: The upper bounds for the solution variables. Defaults to `nothing`.
* `lcons`: The lower bounds for the constraint residuals. Defaults to `nothing`.
* `ucons`: The upper bounds for the constraint residuals. Defaults to `nothing`.
* `problem_type`: The type of the problem, either `StandardBVProblem` or
`TwoPointBVProblem`.
* `kwargs`: The keyword arguments passed onto the solves.

### Special Keyword Arguments
Expand All @@ -127,7 +133,8 @@ struct BVProblem{uType, tType, isinplace, nlls, P, F, LB, UB, LC, UC, PT, K} <:
kwargs::K

@add_kwonly function BVProblem{iip}(f::AbstractBVPFunction{iip, TP}, u0, tspan,
p = NullParameters(); lb = nothing, ub = nothing, lcons = nothing, ucons = nothing, problem_type = nothing, nlls = nothing,
p = NullParameters(); lb = nothing, ub = nothing, lcons = nothing,
ucons = nothing, problem_type = nothing, nlls = nothing,
kwargs...) where {iip, TP}
_u0 = prepare_initial_state(u0)
_tspan = promote_tspan(tspan)
Expand Down Expand Up @@ -347,21 +354,32 @@ every solve call.
initial value problem, or a `Vector` of values for ``u(t_i)`` for collocation
methods.
* `tspan`: The timespan for the problem.
* `p`: The parameters for the problem. Defaults to `NullParameters`
* `p`: The parameters for the problem. Defaults to `NullParameters`.
* `lb`: The lower bounds for the solution variables. Defaults to `nothing`.
* `ub`: The upper bounds for the solution variables. Defaults to `nothing`.
* `lcons`: The lower bounds for the constraint residuals. Defaults to `nothing`.
* `ucons`: The upper bounds for the constraint residuals. Defaults to `nothing`.
* `problem_type`: The type of the problem, either `StandardSecondOrderBVProblem` or
`TwoPointSecondOrderBVProblem`.
* `kwargs`: The keyword arguments passed onto the solves.
"""
struct SecondOrderBVProblem{uType, tType, isinplace, nlls, P, F, PT, K} <:
struct SecondOrderBVProblem{uType, tType, isinplace, nlls, P, F, LB, UB, LC, UC, PT, K} <:
AbstractBVProblem{uType, tType, isinplace, nlls}
f::F
u0::uType
tspan::tType
p::P
lb::LB
ub::UB
lcons::LC
ucons::UC
problem_type::PT
kwargs::K

@add_kwonly function SecondOrderBVProblem{iip}(
f::DynamicalBVPFunction{iip, specialize, TP}, u0, tspan,
p = NullParameters(); problem_type = nothing, nlls = nothing,
p = NullParameters(); lb = nothing, ub = nothing, lcons = nothing,
ucons = nothing, problem_type = nothing, nlls = nothing,
kwargs...) where {iip, specialize, TP}
_u0 = prepare_initial_state(u0)
_tspan = promote_tspan(tspan)
Expand All @@ -377,7 +395,9 @@ struct SecondOrderBVProblem{uType, tType, isinplace, nlls, P, F, PT, K} <:
end

return new{typeof(_u0), typeof(_tspan), iip, typeof(nlls), typeof(p), typeof(f),
typeof(problem_type), typeof(kwargs)}(f, _u0, _tspan, p, problem_type, kwargs)
typeof(lb), typeof(ub), typeof(lcons), typeof(ucons),
typeof(problem_type), typeof(kwargs)}(
f, _u0, _tspan, p, lb, ub, lcons, ucons, problem_type, kwargs)
end

function SecondOrderBVProblem{iip}(
Expand Down
Loading