Add special methods for multiplication of constant scalars #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Author
|
The runtests are failing but only in the Zygote implementation. It should not be related to this PR, as it is also present in other PRs. |
Contributor
Author
|
Hello, any thoughts on this? Would It be possible to review it? I would require this in order to update my package QuantumToolbox.jl. |
ChrisRackauckas
approved these changes
May 3, 2025
Member
|
Sorry I had missed this. Looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I add more methods on the multiplication of constant scalars like
NumberorUniformScalar.This will simplify the structure of the nested operators, when applicable.