Add Ethnologue and ROLV Codes to Language Engagements#1701
Draft
sethmcknight wants to merge 5 commits intodevelopfrom
Draft
Add Ethnologue and ROLV Codes to Language Engagements#1701sethmcknight wants to merge 5 commits intodevelopfrom
sethmcknight wants to merge 5 commits intodevelopfrom
Conversation
…modal - Identify already engaged Languages for a Project in the CreateLanguageEngagement modal
…Engagement.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Enhanced the Create Language Engagement modal to improve language discovery and prevent duplicate engagements by displaying language classification codes and disabling languages that are already engaged on the project.
Improves language selection UX by making language codes visible at selection time.
Changes
Display language codes in dropdown: Each language option now shows:
Language name
Ethnologue code (ETH)
Registry of Language Varieties code (ROLV)
Column headers: Added labeled column headers (Name, ETH, ROLV) for clarity in the dropdown options list
Prevent duplicate engagements:
Languages already engaged on the project are disabled in the dropdown
Disabled options display a tooltip: "Already added to this project"
Already-engaged languages are sorted to the bottom of the list for better UX
Selected language helper text: When a language is selected, its ETH and ROLV codes appear below the field for quick reference
Code clarity: Renamed form field structure from language to engagement throughout the component for consistency with modal intent
Component refactor: Extracted form content into a separate FormContent component for better code organization and reusability