-
Notifications
You must be signed in to change notification settings - Fork 3
Add Ethnologue and ROLV Codes to the Create Language Engagement Lookup Modal #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sethmcknight
wants to merge
14
commits into
develop
Choose a base branch
from
#1112-create-engagement-language-clarity
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
30f031d
- Add Ethnologue Code and ROLV Code to the CreateLanguageEngagements …
sethmcknight fb4947a
- Respond to Copilot review
sethmcknight 02f4e96
Update src/scenes/Engagement/LanguageEngagement/Create/CreateLanguage…
sethmcknight 23fea93
Enhance CreateLanguageEngagement component with option rendering and …
sethmcknight 26cec56
Merge branch 'develop' into #1112-create-engagement-language-clarity
sethmcknight b060142
Refactor CreateLanguageEngagement to use nested engagement structure …
sethmcknight 809803b
Add initial unit tests for new CreateLanguageEngagement components
sethmcknight 4642ea5
Add unit tests for LookupField logic and helper functions
sethmcknight ddeb653
Add tests for sortComparator and renderOptionContent in CreateLanguag…
sethmcknight 4fa3f96
Refactor unit tests in LookupField and CreateLanguageEngagement
sethmcknight ad742c6
Refactor LookupField and CreateLanguageEngagement components to impro…
sethmcknight ba1de74
Refactor CreateLanguageEngagement component and tests to utilize crea…
sethmcknight be90210
Align column header and option code widths for consistent layout in C…
sethmcknight 4c15669
Refactor CreateLanguageEngagement component for improved type safety …
sethmcknight File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.