Skip to content

chore(ci): Fix linting in the seldon_core Python package(mainly)#7015

Merged
vtaskow merged 29 commits intorelease-1.19.0-prepfrom
fix-python-linting-errors
Dec 16, 2025
Merged

chore(ci): Fix linting in the seldon_core Python package(mainly)#7015
vtaskow merged 29 commits intorelease-1.19.0-prepfrom
fix-python-linting-errors

Conversation

@vtaskow
Copy link

@vtaskow vtaskow commented Dec 12, 2025

What

Summary of changes

  • Lint python files and Jupyter notebooks
  • Remove conda from requirements-dev.txt - not needed
  • Remove git diff command from make lint and replace it with make licenses + commit and push in the workflow
    • git diff was not working correctly for some reason, spent some time trying to fix it but coudn't, will re-attempt at a later stage

Checklist

  • Added/updated unit tests
  • Added/updated documentation
  • Checked for typos in variable names, comments, etc.
  • Added licences for new files

Testing

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2025

CLA assistant check
All committers have signed the CLA.

@vtaskow vtaskow force-pushed the fix-python-linting-errors branch from 4713c42 to 66328f4 Compare December 15, 2025 17:24
@vtaskow vtaskow changed the title Fix 1 lint error chore(ci): Fix python lint issues Dec 15, 2025
@vtaskow vtaskow marked this pull request as ready for review December 15, 2025 17:31
@vtaskow vtaskow requested a review from tyndria December 15, 2025 23:58
@vtaskow vtaskow changed the title chore(ci): Fix python lint issues chore(ci): Fix linting in the seldon_core Python package(mainly) Dec 16, 2025
@vtaskow vtaskow merged commit 6624eeb into release-1.19.0-prep Dec 16, 2025
24 of 26 checks passed
@vtaskow vtaskow deleted the fix-python-linting-errors branch December 16, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants