-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[py] remove xfail attr for firefox and safari for cookie tests #14794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
The common test has been removed from the test matrix for safari since it took 3 hours to complete. selenium/.github/workflows/ci-python.yml Line 126 in 4b7d174
|
|
I will try to see what can be done. |
|
I wasn't able to find a way to optimise this. A workaround for this can be simply skipping this in the CI like it's done for other tests I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @Delta456!
…iumHQ#14794) [py] remove xfail attr for firefox and safari Co-authored-by: Diego Molina <[email protected]>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Removes
@pytest.mark.xfail_safariand@pytest.mark.xfail_firefoxattribute for python cookie testsMotivation and Context
As per the docs and tested locally the attribute is no longer needed and can be tested with Safari and FireFox
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
@pytest.mark.xfail_firefoxand@pytest.mark.xfail_safaridecorators from cookie tests, allowing them to run on Firefox and Safari without expected failures.sameSitecookie attribute is now supported in these browsers, aligning with local testing results.Changes walkthrough 📝
cookie_tests.py
Remove xfail markers for Firefox and Safari in cookie testspy/test/selenium/webdriver/common/cookie_tests.py
@pytest.mark.xfail_firefoxdecorator from tests.@pytest.mark.xfail_safaridecorator from tests.