Skip to content

[py] remove xfail attr for firefox and safari for cookie tests #14794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 28, 2024
Merged

[py] remove xfail attr for firefox and safari for cookie tests #14794

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75db292
[py] remove xfail attr for firefox and safari
Delta456 Nov 24, 2024
459c937
Merge branch 'trunk' into test_cookie
Delta456 Nov 24, 2024
caadc0f
Merge branch 'trunk' into test_cookie
Delta456 Nov 28, 2024
4701cd4
Merge branch 'trunk' into test_cookie
diemol Dec 27, 2024
7ce06c9
Merge branch 'trunk' into test_cookie
diemol Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions py/test/selenium/webdriver/common/cookie_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,35 +80,28 @@ def test_add_cookie(cookie, driver):
assert cookie["name"] in returned


@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented")
@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented")
@pytest.mark.xfail_safari
def test_add_cookie_same_site_strict(same_site_cookie_strict, driver):
driver.add_cookie(same_site_cookie_strict)
returned = driver.get_cookie("foo")
assert "sameSite" in returned and returned["sameSite"] == "Strict"


@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented")
@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented")
@pytest.mark.xfail_safari
def test_add_cookie_same_site_lax(same_site_cookie_lax, driver):
driver.add_cookie(same_site_cookie_lax)
returned = driver.get_cookie("foo")
assert "sameSite" in returned and returned["sameSite"] == "Lax"


@pytest.mark.xfail_firefox(reason="sameSite cookie attribute not implemented")
@pytest.mark.xfail_remote(reason="sameSite cookie attribute not implemented")
@pytest.mark.xfail_safari
def test_add_cookie_same_site_none(same_site_cookie_none, driver):
driver.add_cookie(same_site_cookie_none)
# Note that insecure sites (http:) can't set cookies with the Secure directive.
# driver.get_cookie would return None


@pytest.mark.xfail_ie
@pytest.mark.xfail_safari
def test_adding_acookie_that_expired_in_the_past(cookie, driver):
expired = cookie.copy()
expired["expiry"] = calendar.timegm(time.gmtime()) - 1
Expand Down
Loading