Skip to content

Conversation

@pujagani
Copy link
Contributor

@pujagani pujagani commented Feb 11, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement, Bug fix


Description

  • Removed deprecated CDP support for Firefox in CdpEndpointFinder.

  • Updated Bazel build file to remove CDP dependency for Firefox.

  • Streamlined code by eliminating unnecessary warnings for Firefox CDP.


Changes walkthrough 📝

Relevant files
Enhancement
CdpEndpointFinder.java
Remove Firefox CDP support logic from `CdpEndpointFinder`

java/src/org/openqa/selenium/devtools/CdpEndpointFinder.java

  • Removed handling of Firefox-specific CDP key.
  • Eliminated warning message for deprecated Firefox CDP support.
  • Simplified logic for determining CDP support by browser.
  • +0/-8     
    Configuration changes
    BUILD.bazel
    Update Bazel build file to remove Firefox CDP dependency 

    java/src/org/openqa/selenium/firefox/BUILD.bazel

  • Removed CDP dependency for Firefox from Bazel build file.
  • Adjusted dependencies to reflect removal of Firefox CDP support.
  • +0/-1     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @pujagani pujagani marked this pull request as ready for review February 11, 2025 07:55
    @qodo-merge-pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Breaking Change

    Removal of Firefox CDP support is a breaking change that could impact existing tests and automation code relying on Firefox CDP functionality. Ensure this is properly communicated in release notes and documentation.

    switch (caps.getBrowserName()) {
      case "chrome":
        key = "goog:chromeOptions";
        break;
      case "msedge":
        key = "ms:edgeOptions";
        break;
      default:
        return Optional.empty();
    }

    @qodo-merge-pro
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @pujagani pujagani merged commit 4faf5ba into SeleniumHQ:trunk Feb 11, 2025
    3 of 4 checks passed
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant