Skip to content

[py] fix return type and docstring of get_downloadable_files #15292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 17, 2025
Merged

[py] fix return type and docstring of get_downloadable_files #15292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b137092
Revert "add alias attr to all edge structs"
Delta456 Dec 11, 2024
f8e461c
Reapply "add alias attr to all edge structs"
Delta456 Dec 31, 2024
7ad1668
[py] fix return type and docstring of `get_downloadable_files`
Delta456 Feb 17, 2025
5dae938
Merge branch 'trunk' into py_downloadable_files
Delta456 Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions py/selenium/webdriver/remote/webdriver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,9 +1381,8 @@ def set_user_verified(self, verified: bool) -> None:
"""
self.execute(Command.SET_USER_VERIFIED, {"authenticatorId": self._authenticator_id, "isUserVerified": verified})

def get_downloadable_files(self) -> dict:
"""Retrieves the downloadable files as a map of file names and their
corresponding URLs.
def get_downloadable_files(self) -> list:
"""Retrieves the downloadable files as a list of file names.

Example:
--------
Expand Down
1 change: 1 addition & 0 deletions py/test/selenium/webdriver/remote/remote_downloads_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def test_get_downloadable_files(driver, pages):

assert "file_1.txt" in file_names
assert "file_2.jpg" in file_names
assert type(file_names) is list


def test_download_file(driver, pages):
Expand Down
Loading