[py] Remove ability to set env var for SE_SAFARIDRIVER #15855
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
#15849
💥 What does this PR do?
This PR removes the ability to set
SE_SAFARIDRIVERenvironment variable to control the location of safaridriver, since it is not possible to change its location. This brings the Python bindings into alignment with others (i.e. Java bindings) that do not respect this environment variable.Note: you can still pass a key name in the constructor to specify driver location, but I didn't want to change the public API. However, setting a key name is not useful because you can't have safaridriver in an alternate location.
PR Type
Enhancement
Description
Remove support for
SE_SAFARIDRIVERenvironment variableAlign Python Safari driver behavior with other bindings
Simplify
Serviceclass initialization logicChanges walkthrough 📝
service.py
Remove SE_SAFARIDRIVER env var support from Safari Servicepy/selenium/webdriver/safari/service.py
SE_SAFARIDRIVERenv var for driver path