[js][bidi]: fix flaky bidi network test - can request cookies

[navin772]

User description

🔗 Related Issues

💥 What does this PR do?

Fixes the flaky can request cookies test in network_test.js by waiting for cookies to load completely.

🔧 Implementation Notes

The async method doesn't waits for cookie to load completely, adding a driver wait fixes it.

💡 Additional Considerations

🔄 Types of changes

• Cleanup (formatting, renaming)

---

PR Type

Bug fix

---

Description

• Fix flaky BiDi network test by adding wait conditions

• Ensure cookies are loaded before assertions in test

---

Diagram Walkthrough

flowchart LR
  A["Add Cookie"] --> B["Navigate Refresh"] --> C["Wait for Cookies"] --> D["Assert Cookie Values"]

Loading

File Walkthrough

	Relevant files
Bug fix	network_test.js Add wait conditions for cookie loading                                      javascript/selenium-webdriver/test/bidi/network_test.js Added driver.wait() calls to ensure cookies are loaded before assertions Wait for cookie array length to be greater than expected count Prevents race conditions in async cookie loading +2/-0

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌ 1234 - Not compliant Non-compliant requirements: • Fix JavaScript execution in link href on click() for Firefox • Ensure compatibility with Selenium 2.48.x versions • Restore functionality that worked in 2.47.1 5678 - Not compliant Non-compliant requirements: • Fix ChromeDriver ConnectFailure error on Ubuntu 16.04.4 • Resolve connection refused errors for subsequent ChromeDriver instances • Ensure first ChromeDriver instance works without console errors

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Timeout Value The hardcoded 2000ms timeout may be insufficient for slower environments or CI systems, potentially causing intermittent test failures await driver.wait(() => beforeRequestEvent.request.cookies.length > 0, 2000) assert.equal(beforeRequestEvent.request.cookies[0].name, 'north') assert.equal(beforeRequestEvent.request.cookies[0].value.value, 'biryani') const url = beforeRequestEvent.request.url assert.equal(url, await driver.getCurrentUrl()) await driver.manage().addCookie({ name: 'south', value: 'dosa', }) await driver.navigate().refresh() await driver.wait(() => beforeRequestEvent.request.cookies.length > 1, 2000)

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add null safety check Add null check for beforeRequestEvent before accessing its properties. The event might not be captured yet when the wait condition is evaluated, causing potential null reference errors. javascript/selenium-webdriver/test/bidi/network_test.js [72-74] -await driver.wait(() => beforeRequestEvent.request.cookies.length > 0, 2000) +await driver.wait(() => beforeRequestEvent && beforeRequestEvent.request.cookies.length > 0, 2000) assert.equal(beforeRequestEvent.request.cookies[0].name, 'north') assert.equal(beforeRequestEvent.request.cookies[0].value.value, 'biryani') Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential null reference error if beforeRequestEvent is not yet defined when the wait condition is checked, and the proposed fix makes the test more robust.	Medium
Update

[diemol]

Thank you