Skip to content

[js][bidi]: fix flaky bidi network test - can request cookies #16141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

[js][bidi]: fix flaky bidi network test - can request cookies #16141

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0aab21
fix flaky cookie bidi test
navin772 Aug 7, 2025
6cbf2a9
Merge branch 'trunk' into fix-js-bidi-network-test
diemol Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions javascript/selenium-webdriver/test/bidi/network_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ suite(
await driver.navigate().refresh()

assert.equal(beforeRequestEvent.request.method, 'GET')
await driver.wait(() => beforeRequestEvent.request.cookies.length > 0, 2000)
assert.equal(beforeRequestEvent.request.cookies[0].name, 'north')
assert.equal(beforeRequestEvent.request.cookies[0].value.value, 'biryani')
const url = beforeRequestEvent.request.url
Expand All @@ -80,6 +81,7 @@ suite(
})
await driver.navigate().refresh()

await driver.wait(() => beforeRequestEvent.request.cookies.length > 1, 2000)
assert.equal(beforeRequestEvent.request.cookies[1].name, 'south')
assert.equal(beforeRequestEvent.request.cookies[1].value.value, 'dosa')
})
Expand Down
Loading