[rb] fix unit tests

[aguspe]

User description

This pull request makes a small change to the gem specification by adding a new dependency.

• Added the prism gem (version ~> 1.0, < 1.5) as a dependency in rb/selenium-webdriver.gemspec to ensure compatibility with JRuby

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Bug fix

---

Description

• Add prism dependency constraint to Ruby gemspec

• Fix version compatibility issues in unit tests

• Restrict prism to versions 1.0 to 1.5

---

Diagram Walkthrough

flowchart LR
  A["Ruby Gemspec"] --> B["Add prism dependency"] --> C["Fix Unit Tests"]

Loading

File Walkthrough

	Relevant files
Bug fix	selenium-webdriver.gemspec Add prism dependency constraint                                                    rb/selenium-webdriver.gemspec Add prism gem dependency with version constraint ~> 1.0, < 1.5 Fix dependency compatibility issues for Ruby unit tests +1/-0

---

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 1234 - Partially compliant Compliant requirements: Non-compliant requirements: Investigate and fix regression where click() no longer triggers JavaScript in link href in Firefox (2.48.x vs 2.47.1). Ensure behavior works on Firefox 42.0 (32-bit) per report. Provide tests or validation demonstrating the fix. Requires further human verification: Manual validation on affected Firefox version to confirm click() triggers JavaScript in href. Cross-version/browser regression testing to ensure no behavior changes elsewhere. 5678 - Partially compliant Compliant requirements: Non-compliant requirements: Diagnose "ConnectFailure (Connection refused)" when instantiating multiple ChromeDriver instances. Provide a code fix or configuration change to prevent connection failures after the first instance. Add tests or reproducible steps validating multiple instances work reliably. Requires further human verification: Runtime verification by launching multiple ChromeDriver instances across environments.

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Version Constraint The prism dependency is capped to < 1.5 while the description claims 1.0 to 1.5; verify whether 1.5.x should be allowed (<= 1.5) or intentionally excluded (< 1.5) to avoid unintended incompatibilities. s.add_dependency 'prism', ['~> 1.0', '< 1.5'] s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5'] Dependency Impact Adding prism as a runtime dependency may affect downstream consumers; confirm it is required at runtime vs development/test only, and ensure compatibility with supported Ruby versions. s.add_dependency 'prism', ['~> 1.0', '< 1.5'] s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5']

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Use development dependency for test-only gems If the prism gem is only for testing, change its declaration from a runtime dependency (add_dependency) to a development dependency (add_development_dependency). rb/selenium-webdriver.gemspec [54] -s.add_dependency 'prism', ['~> 1.0', '< 1.5'] +s.add_development_dependency 'prism', ['~> 1.0', '< 1.5'] Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential issue where a development dependency is declared as a runtime dependency, which is an important best practice for gem maintainability and user experience.	Medium
More

[exterm]

why restrict prism to < 1.5 ? This means we need to downgrade prism in our app to upgrade selenium-webdriver.

[G-Rath]

Similarly it looks like v4.36.0 (#16332) has done something similar with the json gem - neither of these should be needed by this gem as it is not responsible for ensuring the versions installed are compatible with specific platforms, that's the role of the downstream consumer and their bundler; instead the gem should just be saying what versions it is compatible with.

I can confirm that I've been using selenium-webdriver without issue on the latest versions of prism and json without issue on MRI Ruby for a while

[diemol]

You both have a point. The issue we faced is in our build (we need to use JRuby); the dependencies showed a conflict with Rubocop. We will check this again when releasing 4.37.